Skip to content

Turbopack: Remove the IntoTraitRef trait, make it an inherent method on Vc#91223

Merged
bgw merged 1 commit intocanaryfrom
bgw/into-trait-ref-inherent-method
Mar 13, 2026
Merged

Turbopack: Remove the IntoTraitRef trait, make it an inherent method on Vc#91223
bgw merged 1 commit intocanaryfrom
bgw/into-trait-ref-inherent-method

Conversation

@bgw
Copy link
Member

@bgw bgw commented Mar 11, 2026 •
edited
Loading

This is basically one-shot from Opus 4.6, with a minor tweak to the doc comment by hand.

Discussed this with @lukesandberg, and we realized that there's only one implementation of this trait, so it doesn't make a ton of sense as a trait.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 11, 2026
This was referenced Mar 11, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Mar 11, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw mentioned this pull request Mar 11, 2026
Merged
@bgw bgw requested review from a team and lukesandberg March 11, 2026 22:21
@bgw bgw marked this pull request as ready for review March 11, 2026 22:21
@bgw bgw force-pushed the bgw/turbo-tasks-singleton-docs branch from d67cf95 to 7ad9a2a Compare March 11, 2026 22:24
@bgw bgw force-pushed the bgw/into-trait-ref-inherent-method branch from 5f8a229 to de250e3 Compare March 11, 2026 22:25
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing bgw/into-trait-ref-inherent-method (2e16077) with canary (96b6c00)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on canary (bdf1129) during the generation of this report, so 96b6c00 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 11, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▂▁▁▁
Cold (Ready in log) 438ms 438ms ✓ ▇▂▁▁▁
Cold (First Request) 1.327s 1.237s ✓ ▇▃▁▃▂
Warm (Listen) 456ms 457ms ✓ █▂▁▁▁
Warm (Ready in log) 441ms 443ms ✓ █▂▁▁▁
Warm (First Request) 346ms 347ms ✓ █▃▂▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▆▃▃▃▁
Cold (Ready in log) 437ms 437ms ✓ ▇▂▇▁▅
Cold (First Request) 1.866s 1.867s ✓ ▇▃▅▁▄
Warm (Listen) 456ms 456ms ✓ ▃▁▁▁▁
Warm (Ready in log) 436ms 437ms ✓ ▇▁▄▁▅
Warm (First Request) 1.874s 1.862s ✓ █▃▃▁▄

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.935s 3.901s ✓ ▇▃▁▁▁
Cached Build 3.948s 3.979s ✓ ▇▃▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.127s 14.120s ✓ ▇▆▂▃▁
Cached Build 14.341s 14.368s ✓ ▆▆▂▃▁
node_modules Size 482 MB 482 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **408 kB** → **408 kB** ✅ -9 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 766 B 762 B ✓
Total 766 B 762 B ✅ -4 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B ✓
Total 450 B 450 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.6 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.7 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 253 B 🟢 3 B (-1%)
main-HASH.js gzip 39.2 kB 39.2 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.7 kB -
9544-HASH.js gzip N/A 60.4 kB -
Total 234 kB 234 kB ⚠️ +728 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 266 kB 266 kB ✓
Total 391 kB 391 kB ⚠️ +206 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 617 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.3 kB ✅ -113 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.2 MB 4.19 MB 🟢 7.94 kB (0%)
index.pack gzip 108 kB 108 kB ✓
index.pack.old gzip 108 kB 108 kB ✓
Total 4.42 MB 4.41 MB ✅ -7.87 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 331 kB 331 kB ✓
app-page-exp..prod.js gzip 179 kB 179 kB ✓
app-page-tur...dev.js gzip 331 kB 331 kB ✓
app-page-tur..prod.js gzip 179 kB 179 kB ✓
app-page-tur...dev.js gzip 327 kB 327 kB ✓
app-page-tur..prod.js gzip 177 kB 177 kB ✓
app-page.run...dev.js gzip 328 kB 328 kB ✓
app-page.run..prod.js gzip 178 kB 178 kB ✓
app-route-ex...dev.js gzip 75.9 kB 75.9 kB ✓
app-route-ex..prod.js gzip 51.7 kB 51.7 kB ✓
app-route-tu...dev.js gzip 76 kB 76 kB ✓
app-route-tu..prod.js gzip 51.7 kB 51.7 kB ✓
app-route-tu...dev.js gzip 75.6 kB 75.6 kB ✓
app-route-tu..prod.js gzip 51.5 kB 51.5 kB ✓
app-route.ru...dev.js gzip 75.5 kB 75.5 kB ✓
app-route.ru..prod.js gzip 51.4 kB 51.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB ✓
pages-api-tu..prod.js gzip 33 kB 33 kB ✓
pages-api.ru...dev.js gzip 43.3 kB 43.3 kB ✓
pages-api.ru..prod.js gzip 33 kB 33 kB ✓
pages-turbo....dev.js gzip 52.7 kB 52.7 kB ✓
pages-turbo...prod.js gzip 38.6 kB 38.6 kB ✓
pages.runtim...dev.js gzip 52.7 kB 52.7 kB ✓
pages.runtim..prod.js gzip 38.6 kB 38.6 kB ✓
server.runti..prod.js gzip 62.4 kB 62.4 kB ✓
Total 2.94 MB 2.94 MB ✅ -5 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/1e14368d485b8da8a16826a1925b080844471c7b/next

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 11, 2026 •
edited
Loading

Tests Passed

@bgw bgw force-pushed the bgw/turbo-tasks-singleton-docs branch from 7ad9a2a to dedb6b8 Compare March 12, 2026 18:43
@bgw bgw force-pushed the bgw/into-trait-ref-inherent-method branch from de250e3 to e8f37f2 Compare March 12, 2026 18:43
@bgw bgw force-pushed the bgw/turbo-tasks-singleton-docs branch 2 times, most recently from 8bf500f to 6b3646f Compare March 12, 2026 22:48
@bgw bgw force-pushed the bgw/into-trait-ref-inherent-method branch from e8f37f2 to 1e14368 Compare March 12, 2026 22:48
@bgw bgw changed the base branch from bgw/turbo-tasks-singleton-docs to graphite-base/91223 March 12, 2026 23:34
@bgw bgw force-pushed the graphite-base/91223 branch from 6b3646f to bdf1129 Compare March 12, 2026 23:35
@bgw bgw force-pushed the bgw/into-trait-ref-inherent-method branch from 1e14368 to b1426ca Compare March 12, 2026 23:35
@graphite-app graphite-app bot changed the base branch from graphite-base/91223 to canary March 12, 2026 23:36
@bgw bgw force-pushed the bgw/into-trait-ref-inherent-method branch from b1426ca to 2e16077 Compare March 12, 2026 23:36
@bgw bgw merged commit d7de6f1 into canary Mar 13, 2026
287 of 296 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Mar 13, 2026

Merge activity

  • Mar 13, 5:43 PM UTC: @bgw merged this pull request with Graphite.

@bgw bgw deleted the bgw/into-trait-ref-inherent-method branch March 13, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bgw @nextjs-bot @lukesandberg @mischnic